Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-data-grid] Flowsheet Data Grid - No Result Cell #1830

Merged
merged 13 commits into from
Oct 24, 2023
Merged

Conversation

smason0
Copy link
Contributor

@smason0 smason0 commented Oct 10, 2023

Summary

What was changed:
Added support for "No result" cells, displayed as "--" in the Flowsheet Data Grid.

Why it was changed:
This adds the proper visual indication for when a (non-header) Flowsheet cell has no results, and allows it to be read as "No result" by AT.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-9405


Thank you for contributing to Terra.
@cerner/terra

Sorry, something went wrong.

Copy link
Contributor

@eawww eawww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits but also caught one probably major concern.

Copy link
Contributor

@eawww eawww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few wording changes but otherwise looks great!

@eawww eawww added ⭐ UX Reviewed UX Reviewed and approved. and removed UX Review Required labels Oct 23, 2023
@github-actions github-actions bot temporarily deployed to preview-pr-1830 October 24, 2023 13:02 Destroyed
@adoroshk adoroshk merged commit 3cfb6af into main Oct 24, 2023
@adoroshk adoroshk deleted the UXPLATFORM-9405 branch October 24, 2023 13:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants